Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ascon: update formulas and check for API compatibility #406

Merged
merged 2 commits into from Feb 21, 2023

Conversation

armfazh
Copy link
Contributor

@armfazh armfazh commented Feb 21, 2023

  • Updating code points for Modes.
  • Check the cipher.AEAD interface works as expected.
  • The interface allows to reuse the plaintext to store the ciphertext.

@armfazh armfazh added the tests Include new tests on the code label Feb 21, 2023
@armfazh armfazh self-assigned this Feb 21, 2023
Copy link
Member

@bwesterb bwesterb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little nit.

// more resistance against a quantum adversary using Grover’s algorithm for
// key search. Since Ascon-128 and Ascon-80pq share the same building blocks
// and same parameters except the size of the key, it is claimed the same
// security for Ascon-80pq against classical attacks as for Ascon-128.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't Ascon80pq provide 160b of classical security?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to add although Ascon-128 already reaches approximately NIST level 1 post-quantum security.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meichlseder can give us more details.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text is correct, we don't claim 160 bits of classical security for Ascon-80pq.
Several parts of Ascon are scaled for 128-bit security (with data limit 2^64), including the sponge capacity, tag size, permutation distinguisher bounds, etc., thus the common 128-bit security claim for all variants.
Depending on your precise definition of b-bit security and additional constraints besides offline time complexity (data limits including number of encryption/decryption queries, misuse settings, etc), ymmv.

@armfazh armfazh merged commit eb5ff89 into cloudflare:main Feb 21, 2023
@armfazh armfazh deleted the asconCte branch February 21, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Include new tests on the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants